Skip to content

Check pyvista version in _TimeViewer #7506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
larsoner merged 1 commit into from
Mar 24, 2020
Merged

Check pyvista version in _TimeViewer #7506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions mne/viz/_brain/_timeviewer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,9 @@ class _TimeViewer(object):
"""Class to interact with _Brain."""

def __init__(self, brain, show_traces=False):
from ..backends._pyvista import _require_minimum_version
_require_minimum_version('0.24')

# Default configuration
self.playback = False
self.visibility = True
Expand Down
9 changes: 9 additions & 0 deletions mne/viz/backends/_pyvista.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -644,6 +644,15 @@ def _update_picking_callback(plotter,
plotter.picker = picker


def _require_minimum_version(version_required):
from distutils.version import LooseVersion
version = LooseVersion(pyvista.__version__)
if version < version_required:
raise ImportError('pyvista>={} is required for this module but the '
'version found is {}'.format(version_required,
version))


@contextmanager
def _testing_context(interactive):
from . import renderer
Expand Down