Skip to content

Conversation

@GuillaumeFavelier
Copy link
Contributor

This PR adds a shortcut c to clear all traces, the help window is also updated.

Here is an animation with show_traces='separate':

output

It's an item of #7162

@GuillaumeFavelier GuillaumeFavelier self-assigned this Mar 4, 2020
@GuillaumeFavelier GuillaumeFavelier changed the title Add clear_points Add clear_points in _TimeViewer Mar 4, 2020
@larsoner larsoner added this to the 0.20 milestone Mar 4, 2020
('i', 'Toggle interface'),
('s', 'Apply auto-scaling'),
('r', 'Restore original clim'),
('c', 'Clear all traces'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pressing c is not working for me. Did you forget to configure the callback?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also pressing i or s does not work anymore for me :(

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you try with pyvista 0.23.1?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now the recommended version:
#7162 (comment)

@agramfort
Copy link
Member

agramfort commented Mar 4, 2020 via email

@larsoner larsoner merged commit e88179a into mne-tools:master Mar 4, 2020
@GuillaumeFavelier GuillaumeFavelier mentioned this pull request Mar 5, 2020
86 tasks
AdoNunes pushed a commit to AdoNunes/mne-python that referenced this pull request Apr 6, 2020
AdoNunes pushed a commit to AdoNunes/mne-python that referenced this pull request Apr 6, 2020
@GuillaumeFavelier GuillaumeFavelier deleted the time_viewer_clear_traces branch June 11, 2020 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants