FIX,VIZ: Update read_curvature #7289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeFavelier
changed the title
agramfort
reviewed
Feb 5, 2020
mne/surface.py
Outdated
|
|
||
| def read_curvature(filepath): | ||
| def read_curvature(filepath, binary=True): | ||
| """Load in curavature values from the ?h.curv file.""" |
Member
There was a problem hiding this comment.
I am surprised there is no docstring in this funciton and CIs don't complain. Can you add it?
Member
There was a problem hiding this comment.
It's not checked because mne.surface is not in the public_modules list in mne/tests/test_docstring_parameters.py list. @GuillaumeFavelier feel free to add it. You might then need to fix some docstrings and/or add entries to docstring_ignores
Codecov Report
@@ Coverage Diff @@
## master #7289 +/- ##
=======================================
Coverage 89.80% 89.80%
=======================================
Files 447 447
Lines 80572 80572
Branches 12873 12873
=======================================
Hits 72360 72360
Misses 5385 5385
Partials 2827 2827 |
agramfort
approved these changes
Feb 5, 2020
| Input path to the .curv file. | ||
| binary: bool | ||
| Specify if the output array is to hold binary values. Defaults to True. | ||
|
|
mne/surface.py
Outdated
|
|
||
| Parameters | ||
| ---------- | ||
|
|
Contributor
Author
This seems beyond the scope of this PR, I noted it in #7162 |
86 tasks
larsoner
approved these changes
Feb 5, 2020
Member
|
Thanks @GuillaumeFavelier |
AdoNunes
pushed a commit
to AdoNunes/mne-python
that referenced
this pull request
Apr 6, 2020
* Update read_curvature * Improve docstring * Fix docstring
AdoNunes
pushed a commit
to AdoNunes/mne-python
that referenced
this pull request
Apr 6, 2020
* Update read_curvature * Improve docstring * Fix docstring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR fixes the
load_curvature()function of the_Brainobject.master