Skip to content

[RELEASE][DOC] Archive 0.16 and add 0.17 to navigation bar#5723

Merged
massich merged 3 commits intomne-tools:masterfrom
massich:doc_add_0.17_to_navigation_bar
Nov 19, 2018
Merged

[RELEASE][DOC] Archive 0.16 and add 0.17 to navigation bar#5723
massich merged 3 commits intomne-tools:masterfrom
massich:doc_add_0.17_to_navigation_bar

Conversation

@massich
Copy link
Contributor

@massich massich commented Nov 19, 2018

@larsoner
Copy link
Member

Might as well bump the version numbers in .circle.yml at the same time

@larsoner
Copy link
Member

Oh wait, you haven't bumped the version number to 0.17 yet, nevermind :)

@massich
Copy link
Contributor Author

massich commented Nov 19, 2018

No I haven't but maybe I can do it here and I can use this as PR example

@massich massich force-pushed the doc_add_0.17_to_navigation_bar branch from 5d20f29 to 5a02d93 Compare November 19, 2018 16:20
@massich
Copy link
Contributor Author

massich commented Nov 19, 2018

What have I done wrong?
In this artifact https://10250-1301584-gh.circle-artifacts.com/0/html/index.html it appears to be the dev version but it should not

image

@larsoner
Copy link
Member

larsoner commented Nov 19, 2018

This is fine for an intermediate stage. It will look wrong until you push maint/0.17 and bump the master version to 0.18.

@larsoner
Copy link
Member

(In other words, as long as you continue to follow the release instructions, it should all work out in the end. There are times/commits for which things are incorrect, like they will be now, because we let CircleCI push website changes, which takes a while, and there are steps in between that we must take.)

@massich massich merged commit 5b1ac27 into mne-tools:master Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants