Skip to content

Refactoring eyetracking.py #13602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
larsoner merged 3 commits into from
Jan 20, 2026
+2 −16
Merged

Refactoring eyetracking.py #13602

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0375012
Refactoring eyetracking.py
1himan Jan 20, 2026
758957e
Merge branch 'main' into eyetracking-refactor
1himan Jan 20, 2026
8189691
Adding changelog
1himan Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/changes/dev/13602.other.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Code refactor in :func:`mne.preprocessing.eyetracking.set_channel_types_eyetrack`, by `Himanshu Mahor`_.
17 changes: 1 addition & 16 deletions mne/preprocessing/eyetracking/eyetracking.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,22 +113,7 @@ def set_channel_types_eyetrack(inst, mapping):
inst.info["chs"][c_ind]["unit"] = unit_new

# set eye (and x/y-component)
loc = np.array(
[
np.nan,
np.nan,
np.nan,
np.nan,
np.nan,
np.nan,
np.nan,
np.nan,
np.nan,
np.nan,
np.nan,
np.nan,
]
)
loc = np.full(12, np.nan)

ch_eye = ch_desc[2].lower()
if ch_eye not in valid_eye["all"]:
Expand Down