-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
doc: point to read_dipole #13149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: point to read_dipole #13149
Conversation
|
For formats we inherited those from Elekta/Neuromag/MEGIN. The |
Co-authored-by: Stefan Appelhoff <stefan.appelhoff@mailbox.org>
larsoner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Committed that change and marking for merge-when-green, thanks @sappelhoff !
Okay -- thanks for the pointer :) I am still not very sure why (1) there are three formats, (2) what advantages they have over each other, (3) which non-mne softwares produce them, and (4) whether some dipoles (fixed, non-fixed) can only be saved in some but not other formats 🤔 For (4) I think you say that any dipole can be saved and loaded from any format (fif, dip, bdip) for (3) I know have heard of "xfit", which seems to be Neuromag/Elekta/MEGIN proprietary software (?) for (2) dip and bdip are the same except that one is binary and therefore saves disk space? ... but why is there also FIF then? -- this is related to (1) |
Maybe it's easier to think of in terms of the type of fit you do:
I think Xfit (Neuromag dipole fitting software) can write both formats. |
Sounds like we should add a Notes section with some version of what @larsoner just posted:
|
|
Thanks Eric, and agreed Dan. I can look into this as part of my #13153 or in a separate PR. |
* upstream/main: (149 commits) FIX make_watershed_bem to handle missing talairach_with_skull.lta courtesy Freesurfer 8 (mne-tools#13172) ENH: Add upsampling for MEG helmet surface (mne-tools#13179) MAINT: Update code credit (mne-tools#13180) BUG: Fix bug with least-squares sphere fit (mne-tools#13178) fix EDF export (mne-tools#13174) fix typo (mne-tools#13171) [pre-commit.ci] pre-commit autoupdate (mne-tools#13164) Fix dev installation guide (mne-tools#13163) expose 'mode' for plotting dipole on brain (mne-tools#13162) turn dipole attrs into properties (mne-tools#13153) remove misformatted (and unused) crossref anchor (mne-tools#13155) doc: point to read_dipole (mne-tools#13149) [pre-commit.ci] pre-commit autoupdate (mne-tools#13152) BUG: Fix bug with not short-circuiting n_jobs=1 (mne-tools#13147) FIX: Missing coordinates.xml in MFF file (mne-tools#13148) FIX: Gracefully handle bad XML files in EGI reader (mne-tools#13145) Fixes for Latest IPython (9.0.1) (mne-tools#13146) Fix intersphinx (mne-tools#13143) BUG: Fix bug with parallel doc build (mne-tools#13140) [pre-commit.ci] pre-commit autoupdate (mne-tools#13141) ...
This PR also comes with a question: Why do we support saving Dipoles in dip and bdip, but FixedDipoles in FIF? would it not be possible to support all formats for all objects?
https://mne.tools/stable/generated/mne.DipoleFixed.html#mne.DipoleFixed.save
https://mne.tools/stable/generated/mne.Dipole.html#mne.Dipole.save