-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[MRG] Improves functionality of ANT Neuro reader #12810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…on for read_ant()
|
@mscheltienne here is the MNE pull request. Could you please review the test functions? Thanks! |
larsoner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me but I'll let @mscheltienne comment!
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
|
@mscheltienne how shall we handle different datasets for testing? If I use |
|
I'll cut the 0.3.0 release tomorrow and will have a look at this PR then, I'm not sure I understand this last comment from my phone only. |
I haven't looked closely as to why you need to define those extra funcs ( |
|
I pushed a couple of changes, LGTM. If vulture complies, then the function should be added to |
Improves functionality added in #12792
What does this implement/fix?
RawANT.info:'subject_info'('his_id','first_name','sex','birthday')'device_info'('type','model','serial','site')'meas_date'preload=Falseargument) inread_raw_ant()Additional information
This requires bumping up the
antioversion to0.3.0.dev0.