MRG: Add ICA's fit_params to HTML representation#12194
Merged
larsoner merged 2 commits intomne-tools:mainfrom Nov 13, 2023
Merged
MRG: Add ICA's fit_params to HTML representation#12194larsoner merged 2 commits intomne-tools:mainfrom
fit_params to HTML representation#12194larsoner merged 2 commits intomne-tools:mainfrom
Conversation
hoechenberger
requested review from
adam2392,
agramfort,
cbrnr,
dengemann,
drammock,
larsoner and
mscheltienne
as code owners
hoechenberger
changed the title
fit_params to HTML representationfit_params to HTML representation
hoechenberger
commented
Nov 11, 2023
wmvanvliet
approved these changes
Nov 13, 2023
Member
|
Thanks @hoechenberger ! |
larsoner
added a commit
to hoechenberger/mne-python
that referenced
this pull request
Nov 13, 2023
…o-pyproject.toml * upstream/main: MRG: Add ICA's `fit_params` to HTML representation (mne-tools#12194)
snwnde
pushed a commit
to snwnde/mne-python
that referenced
this pull request
Mar 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was experimenting with different optional
fit_paramswhen working with ICA, generating Reports that included the HTML representation of ICA instances. However, I then realized that we don't display those fit parameters yet, even though we apply some defaults if the user doesn't explicitly pass any values. This PR adds this feature: