[WIP] [BUG] Display title in plot_compare_evokeds when axes='topo'#12192
Merged
larsoner merged 9 commits intomne-tools:mainfrom Nov 14, 2023
Merged
[WIP] [BUG] Display title in plot_compare_evokeds when axes='topo'#12192larsoner merged 9 commits intomne-tools:mainfrom
larsoner merged 9 commits intomne-tools:mainfrom
Conversation
for more information, see https://pre-commit.ci
Contributor
Author
|
The title is too small @larsoner. Any preference for how it should be formatted? |
Contributor
Author
|
My solution was a bit sloppy so I can try something else if needed |
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
Contributor
Author
|
Ready for merge @larsoner! The function didn't autocomplete when I typed it in in devel so I hope I specified it correctly. |
Member
|
Can you go to https://app.circleci.com/pipelines/github/mne-tools/mne-python/21836/workflows/7c69bd2c-835a-428b-b60b-1fe65b988098/jobs/61390 and log in with GitHub? It will allow CircleCI to build your PRs |
Contributor
Author
Contributor
Author
|
Sorry, I had to merge again. I am not sure why the CircleCI test is failing. I logged in. |
Contributor
Author
|
I think there is something wrong with the tests. All of my PRs are failing. I ran them locally: |
Member
|
Failures are unrelated and should be fixed in #12178 |
Member
|
Thanks @withmywoessner ! |
snwnde
pushed a commit
to snwnde/mne-python
that referenced
this pull request
Mar 20, 2024
…ne-tools#12192) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Reference issue
Example: Fixes #12191.
What does this implement/fix?
Add title to topoplot in
plot_compare_evokedsAdditional information
Any additional information you think is important.