Skip to content

Add UI Event linking to DraggableColorbar#12057

Merged
wmvanvliet merged 19 commits intomne-tools:mainfrom
ruuskas:uievents
Oct 5, 2023
Merged

Add UI Event linking to DraggableColorbar#12057
wmvanvliet merged 19 commits intomne-tools:mainfrom
ruuskas:uievents

Conversation

@ruuskas
Copy link
Contributor

@ruuskas ruuskas commented Oct 3, 2023

This change makes the DraggableColorbar class work with UI Events. Users can now link figures that contain topoplots or epoch/tfr images and manipulate the color scale and color map interactively.

Basic example based on the Using the event system to link figures tutorial.

import mne
from mne.viz.ui_events import link

# Turn on interactivity
plt.ion()
data_path = mne.datasets.sample.data_path()
evokeds_fname = data_path / "MEG" / "sample" / "sample_audvis-ave.fif"
evokeds = mne.read_evokeds(evokeds_fname)

left_auditory = evokeds[0]
right_auditory = evokeds[1]

fig1 = left_auditory.plot_topomap("interactive")
fig2 = right_auditory.plot_topomap("interactive")

link(fig1, fig2)

@ruuskas
Add UI Event linking to DraggableColorbar
bbcb16a 
This change makes the DraggableColorbar class work with UI Events. Users
can now link figures that contain topoplots or epoch/tfr images and
manipulate the color scale and color map interactively.
ruuskas and others added 2 commits October 3, 2023 16:51
@ruuskas
Use full cmap docstring for plot_topomap
8cdc5fe 
The full docstring includes info on the interactive functionality.
@ruuskas
Merge branch 'mne-tools:main' into uievents
330007f
@larsoner
Copy link
Member

larsoner commented Oct 3, 2023

Ideally every change should have an updated test. Can you look to see if _fake_click can be used to trigger a change in the colorbar and emit your new UIEvent?

@larsoner
Copy link
Member

larsoner commented Oct 3, 2023

... also needs a doc/changes/devel.rst update to mention this enhancement

wmvanvliet
wmvanvliet reviewed Oct 4, 2023
View reviewed changes
@ruuskas ruuskas requested a review from dengemann as a code owner October 4, 2023 06:48
@wmvanvliet
Copy link
Contributor

wmvanvliet commented Oct 4, 2023

CI failure "Test Windows 3.11 pip pre" is not releated to this PR

@drammock
Copy link
Member

drammock commented Oct 4, 2023

CI failure "Test Windows 3.11 pip pre" is not releated to this PR

agreed, @larsoner snuck a fix into #12064

ruuskas added 2 commits October 4, 2023 14:16
@ruuskas
Fix colormap update bug
f7f2fa8 
Colormaps now update across figures also after interacting with the time
 slider.
@ruuskas
Add whats_new.rst entry
17b0c74
wmvanvliet
wmvanvliet reviewed Oct 4, 2023
View reviewed changes
Copy link
Contributor

@wmvanvliet wmvanvliet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great. Only a few nickpicks regarding kind

ruuskas and others added 7 commits October 4, 2023 15:22
@ruuskas
Copy link
Contributor Author

ruuskas commented Oct 5, 2023

@wmvanvliet Any idea why the CI doctest fails?

@wmvanvliet
Copy link
Contributor

wmvanvliet commented Oct 5, 2023

seems unrelated. Let's try again with latest main merged in.

@ruuskas
Copy link
Contributor Author

ruuskas commented Oct 5, 2023

This should be good now @wmvanvliet

@wmvanvliet wmvanvliet merged commit cedefa0 into mne-tools:main Oct 5, 2023
@wmvanvliet
Copy link
Contributor

wmvanvliet commented Oct 5, 2023

Thanks @ruuskas!

larsoner added a commit to larsoner/mne-python that referenced this pull request Oct 10, 2023
@larsoner
Merge remote-tracking branch 'upstream/main' into kernel
f952d58 
* upstream/main: (37 commits)
  Use constrained layout in matplotlib visualization (mne-tools#12050)
  Add raw stc (mne-tools#12001)
  [MRG] update codeowners (mne-tools#12089)
  DOC: Morlet wavelet length in tfr_morlet (mne-tools#12073)
  BUG: Fix bug with mne browser backend (mne-tools#12078)
  Cache avatars (mne-tools#12077)
  BUG: Fix bug with ch_name resolution (mne-tools#12086)
  add unicode roundtrip for FIF (mne-tools#12080)
  add Ivan to names.inc (mne-tools#12081)
  MAINT: Work around PySide 6.5.3 event loop error (mne-tools#12076)
  mne-tools#11608, buggfix and docstring update (mne-tools#12066)
  MAINT: Fix broken examples (mne-tools#12074)
  Add UI Event linking to DraggableColorbar (mne-tools#12057)
  handle lazy loading through .pyi type stubs (mne-tools#12072)
  BUG: Fix bug with sensor_colors (mne-tools#12068)
  clean  up some deprecations (mne-tools#12067)
  Allow not dropping bads when creating or plotting Spectrum objs (mne-tools#12006)
  Collapsible html repr for raw/info (mne-tools#12064)
  BUG: Fix bug with pickling MNEBadsList (mne-tools#12063)
  add details for Denis (mne-tools#12065)
  ...
snwnde pushed a commit to snwnde/mne-python that referenced this pull request Mar 20, 2024
@ruuskas @wmvanvliet @snwnde
Add UI Event linking to DraggableColorbar (mne-tools#12057)
242c18e 
Co-authored-by: Santeri Ruuskanen <santeri.ruuskanen@aalto.fi>
Co-authored-by: Marijn van Vliet <w.m.vanvliet@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wmvanvliet wmvanvliet wmvanvliet left review comments

@drammock drammock Awaiting requested review from drammock drammock is a code owner

@cbrnr cbrnr Awaiting requested review from cbrnr

@dengemann dengemann Awaiting requested review from dengemann

@larsoner larsoner Awaiting requested review from larsoner larsoner is a code owner

@agramfort agramfort Awaiting requested review from agramfort agramfort is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ruuskas @larsoner @wmvanvliet @drammock

Comments