Skip to content

MAINT: Bump minimums#11557

Merged
larsoner merged 7 commits intomne-tools:mainfrom
larsoner:min
Mar 15, 2023
Merged

MAINT: Bump minimums#11557
larsoner merged 7 commits intomne-tools:mainfrom
larsoner:min

Conversation

@larsoner
Copy link
Member

@larsoner larsoner commented Mar 14, 2023

Bumps min reqs in README.rst to those ~2 years old this April, and adjusts/removes code shims for deps lower than those. Also nibabel is now required for read_surface which I think is reasonable (it is pure Python and has been stable and pip/conda-installable for years now).

Closes #10977

@larsoner
Copy link
Member Author

... if we make anything a new core dep in the future, we could consider doing it with nibabel. We could remove a lot of checks by doing it. And maintenance overhead shouldn't be bad because it's a pure-python dependency with a slow-moving deprecation cycle.

Copy link
Member

@drammock drammock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git grep matplotlib.*version shows a few more:

mne/fixes.py:923:    if _compare_version(matplotlib.__version__, '>=', '3.2.0'):
mne/viz/_brain/_scraper.py:74:                    _compare_version(matplotlib.__version__, '>=', '3.3.1') and
mne/viz/_mpl_figure.py:1324:        # XXX when matplotlib 3.3 is min version, replace this with
mne/viz/tests/test_topomap.py:244:    # ...but not all matplotlib versions support it, and we can't use

@drammock
Copy link
Member

git grep matplotlib.*version shows a few more:

I can tackle those if you don't have time.

@larsoner
Copy link
Member Author

Nice catch! I think I got those now

Copy link
Member

@drammock drammock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will mark for merge-when-green; thx @larsoner

@drammock drammock enabled auto-merge (squash) March 14, 2023 16:48
@larsoner
Copy link
Member Author

_________ test_plot_evoked_topomap_units[testing_data-None-None-\xb5V] _________
mne/viz/tests/test_topomap.py:240: in test_plot_evoked_topomap_units
    assert len(cbar) == 1
E   assert 0 == 1
E    +  where 0 = len([])

I'll revert that last commit. The comment didn't specify/know the matplotlib version where we could use the simpler version... apparently it's something after 3.4!

Copy link
Member

@agramfort agramfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@larsoner
Copy link
Member Author

pydata-sphinx-theme building failed on Windows and 0.13.1 is now out (as of about a week ago) so I'm going to pin to that. It gives us about a month to see issues with dev docs and either fix them before release or relax/revert the pin. In the meantime it'll speed up the doc builds

@drammock
Copy link
Member

pydata-sphinx-theme building failed on Windows and 0.13.1 is now out (as of about a week ago) so I'm going to pin to that.

FYI I've been (quietly) trying to fix our site config to look good with 0.13.1. The one thing I haven't been able to fix yet is that we somehow lost margin/padding between the gallery tiles on the homepage, but it actually happened a while ago and I haven't had time to track down what PST change triggered it (I suspect it was the bootstrap4 -> bootstrap5 migration). So feel free to ignore that particular doc issue.

@larsoner larsoner disabled auto-merge March 15, 2023 02:29
@larsoner larsoner merged commit 29e99c8 into mne-tools:main Mar 15, 2023
@larsoner
Copy link
Member Author

Circle is having a bad day so merged manually

@larsoner larsoner deleted the min branch March 15, 2023 02:29
larsoner added a commit to larsoner/mne-python that referenced this pull request Mar 17, 2023
* upstream/main:
  MAINT: Bump minimums (mne-tools#11557)
  Bump minimum Python to 3.8 (mne-tools#11550)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update theme pin and check docs build

3 participants