Skip to content

MAINT: Deal with pkg_resources usage bugs #11478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
larsoner merged 4 commits into from
Feb 15, 2023
Merged

MAINT: Deal with pkg_resources usage bugs #11478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2f42e2d
MAINT: Deal with pkg_resources usage bugs
larsoner Feb 15, 2023
520f378
FIX: Tests, too
larsoner Feb 15, 2023
59e5536
FIX: Avoid flaky test
larsoner Feb 15, 2023
ac00a46
FIX: Another
larsoner Feb 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions doc/conf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1007,6 +1007,9 @@ def reset_warnings(gallery_conf, fname):
'Enum value .* is marked as deprecated',
# matplotlib PDF output
'The py23 module has been deprecated',
# pkg_resources
'Implementing implicit namespace packages',
'Deprecated call to `pkg_resources',
):
warnings.filterwarnings( # deal with other modules having bad imports
'ignore', message=".*%s.*" % key, category=DeprecationWarning)
Expand Down
3 changes: 3 additions & 0 deletions mne/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,9 @@ def pytest_configure(config):
# PySide6
ignore:Enum value .* is marked as deprecated:DeprecationWarning
ignore:Function.*is marked as deprecated, please check the documentation.*:DeprecationWarning
# pkg_resources usage bug
ignore:Implementing implicit namespace packages.*:DeprecationWarning
ignore:Deprecated call to `pkg_resources.*:DeprecationWarning
""".format(first_kind) # noqa: E501
for warning_line in warning_lines.split('\n'):
warning_line = warning_line.strip()
Expand Down
5 changes: 4 additions & 1 deletion mne/viz/_brain/tests/test_brain.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1126,7 +1126,10 @@ def _create_testing_brain(hemi, surf='inflated', src='surface',
return brain_data


def test_foci_mapping(tmp_path, renderer_interactive_pyvistaqt):
# TODO: allow_unclosed for macOS here as the conda build shows some
# windows stay open afterward
def test_foci_mapping(tmp_path, renderer_interactive_pyvistaqt,
allow_unclosed):
"""Test mapping foci to the surface."""
tiny_brain, _ = tiny(tmp_path)
foci_coords = tiny_brain.geo['lh'].coords[:2] + 0.01
Expand Down