BUG: add missing verbose argument in combine_channels function#11253
Merged
larsoner merged 1 commit intomne-tools:mainfrom Oct 17, 2022
Merged
BUG: add missing verbose argument in combine_channels function#11253larsoner merged 1 commit intomne-tools:mainfrom
verbose argument in combine_channels function#11253larsoner merged 1 commit intomne-tools:mainfrom
Conversation
|
Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴🏽♂️ |
Member
|
@dissagaliyeva can I ask you to add a line in latest.inc with the change and your name in names.inc? 🙏 |
Contributor
Author
|
@agramfort hi! is it necessary to do so if our names have already been included in this PR #11245? |
Member
|
indeed let's say no. Your name will appear in changelog then already. |
|
🎉 Congrats on merging your first pull request! 🥳 Looking forward to seeing more from you in the future! 💪 |
Member
|
Thanks @dissagaliyeva ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference issue
Closes #11252
What does this implement/fix?
Adds the missing
verbosecommand to thecombine_channelsfunction.Additional information
Changed three lines of code: