-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't fail if emptyroom is missing cHPI channels #977
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at:
$ git grep mf_filter
...
mne_bids_pipeline/tests/configs/config_ds004229.py:mf_filter_chpi = False # for speed, not needed as we low-pass anyway
maybe having this True
would have caught the error on main
. Do you want to check? If not I can try quickly.
Either way might be good to set to True assuming in only adds a reasonable amount of time on CircleCI (e.g., < 1 minute more is reasonable, > 3 minutes probably isn't).
Locally
took I also realized that we should filter cHPI before performing movement compensation, so I changed that order and added it in the changelog as a bugfix. Marking for merge-when-green, thanks in advance @drammock ! |
heh, you beat me to it, was just about to check for that failure on main |
Nice 🙂 And just for the sake of completeness, I'll add that changing it to True had a negligible effect on testing time (took |
closes #974
Before merging …
docs/source/changes.md
)