DOC: Automatic flowchart #860
Conversation
|
@SophieHerbst can you see if this fixes the wording issue(s) you ran into or if there is more to do? |
| @@ -224,7 +224,7 @@ def apply_ica_raw( | |||
| raw_fname = in_files.pop(in_key) | |||
| assert len(in_files) == 0, in_files | |||
| out_files = dict() | |||
| out_files[in_key] = raw_fname.copy().update(processing="clean") | |||
| out_files[in_key] = raw_fname.copy().update(processing="clean", split=None) | |||
There was a problem hiding this comment.
Should we check all code that generates output filenames to ensure we set split=None everywhere?
There was a problem hiding this comment.
I think we could do it in the function that prepares the output filenames actually. I'll give it a shot
|
@larsoner is the 'temporal regression for artifact removal' a default step? I am not aware that I am using it. |
|
most of the steps are optional though.... we'd end up with almost everything being marked as such |
|
mh right. I am wondering how to make it clearer which config options trigger which steps (or their re-run) |
|
there are in theory this information could be used |
|
Used as in informing the documentation? |
Yes We'd basically have to iterate over all steps and grep the arguments used in |
|
Opened #862 and #861 so we can iterate further in follow-up PRs. This one in the meantime is 90% a bugfix for missing / incorrect information at the moment (the other 10% being the ICA/SSP enhancement to try and make that part clearer) -- @SophieHerbst @hoechenberger happy with those parts so we can merge this? |
|
yes, this is great! feel free to merge whenever you feel it's ready 👍👍👍 |
Before merging …
docs/source/changes.md)Locally produces:
@hoechenberger feel free to push directly wording changes you want. Locally you can iterate pretty easily with:
then refreshting
http://localhost:8000/features/overview.htmlin your browser.