Skip to content

Commit

Permalink
[ncl] Configure NCL for EAS, make notifications work (expo#17590)
Browse files Browse the repository at this point in the history
Why
---
NCL uses the modern manifest format but was not configured for EAS, which meant that it could not register for notifications.

How
---
Added the extra->eas section (ran `eas init` while logged in with the community account).

Test Plan
---
Opened NCL in Expo Go, went to Notifications, sent myself a push notification. Instead of getting an unhandled promise rejection warning, I received a notification.
  • Loading branch information
ide authored May 21, 2022
1 parent 23dd35d commit d2985c7
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion apps/native-component-list/app.json
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,11 @@
"assets/**",
"node_modules/react-navigation/src/**/*.png",
"node_modules/@expo/vector-icons/fonts/*.ttf"
]
],
"extra": {
"eas": {
"projectId": "2c28de10-a2cd-11e6-b8ce-59d1587e6774"
}
}
}
}

0 comments on commit d2985c7

Please sign in to comment.