Skip to content

Sweep abandoned blocks in eager sweeping #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 21, 2023

Conversation

qinsoon
Copy link
Member

@qinsoon qinsoon commented May 25, 2023

This PR fixes part of the issues in #824:

  • Remove the incorrect abandon_blocks() call in FreeListAllocator::reset() for eager sweeping. The incorrect call caused blocks to be pushed to the global abandoned list before they are swept locally by the allocator.
  • Add global sweeping that sweeps the abandoned list.

@qinsoon qinsoon added the PR-testing Run binding tests for the pull request (deprecated: use PR-extended-testing instead) label May 30, 2023
@wks wks mentioned this pull request Jun 16, 2023
5 tasks
@qinsoon qinsoon marked this pull request as ready for review June 19, 2023 05:40
@qinsoon qinsoon requested a review from wks June 19, 2023 05:40
Copy link
Collaborator

@wks wks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

It looks like the current implementation prefers the C-style while loop over the idiomatic for loop over range. It's a minor style problem. We can refactor it later.

@qinsoon
Copy link
Member Author

qinsoon commented Jun 20, 2023

It looks good to me.

It looks like the current implementation prefers the C-style while loop over the idiomatic for loop over range. It's a minor style problem. We can refactor it later.

I changed a few occurrences of C-style loop to Rust for loop.

@qinsoon qinsoon merged commit 02b57a9 into mmtk:master Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-testing Run binding tests for the pull request (deprecated: use PR-extended-testing instead)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants