Map and Mmapper as trait objects
#732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qinsoon
force-pushed
the
dyn-vmmap-mmapper
branch
from
167536c to
94c5063
Compare
qinsoon
reviewed
Mar 21, 2023
wenyuzhao
added a commit
to wenyuzhao/mmtk-core
that referenced
this pull request
Mar 22, 2023
This PR converts `Map` and `Mmapper` instances into trait objects, which builds an abstraction layer over the different VM allocation and mapping policy. This is useful for compressed pointers or 39-bit virtual space support, as they will need to use a different `Map` or `Mmapper` other than the default 64-bit implementation. --------- Co-authored-by: Yi Lin <qinsoon@gmail.com> (cherry picked from commit 5cff944)
qinsoon
pushed a commit
that referenced
this pull request
Aug 24, 2023
This CL refactors the `vm_layout_constants` related code and changes all the related compile-time constants to run-time constants, so that VM bindings can configure them during boot time based on dynamic user inputs. This is a necessary refactoring to support compressed pointers. For most of the VMs (e.g. OpenJDK), compressed pointers are enabled at run-time based on command line arguments, and VM bindings should be able to enable compressed pointer heap dynamically during the VM boot process. Such a process usually involves dynamically configuring heap ranges, space memory layout, and choosing a different `VMMap` implementation [1]. Thus all `vm_layout_constants`, including heap constants, should be made as boot-time configurable, instead of compile-time constants. This CL also makes risc-v's 39-bit heap support easier, as it now should only involve adding a new set of `vm_layout_constants`. [1] This is already done by #732
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR convert
MapandMmapperinstances into trait objects, which builds an abstraction layer over the different VM allocation and mapping policy. This is useful for compressed pointers or 39-bit virtual space support, as they will need to use a differentMaporMmapperother than the default 64-bit implementation.