Skip to content

Conversation

@qinsoon
Copy link
Member

@qinsoon qinsoon commented May 13, 2021

This PR aims to reduce the number of public modules we expose from mmtk-core. It closes #241.

This PR

  • turns each public module to private or pub crate if possible
  • adds some comments
  • removes some unused code/macros

@qinsoon
Copy link
Member Author

qinsoon commented May 13, 2021

jikesrvm-binding-test
JIKESRVM_BINDING_REF=limit-public-api

@qinsoon
Copy link
Member Author

qinsoon commented May 13, 2021

openjdk-binding-test
OPENJDK_BINDING_REF=limit-public-api

@qinsoon
Copy link
Member Author

qinsoon commented May 13, 2021

v8-binding-test
V8_BINDING_REF=limit-public-api

@qinsoon qinsoon marked this pull request as ready for review May 13, 2021 05:41
@qinsoon qinsoon added the PR-testing Run binding tests for the pull request (deprecated: use PR-extended-testing instead) label May 13, 2021
@qinsoon qinsoon requested a review from javadamiri May 13, 2021 05:42
Copy link
Contributor

@javadamiri javadamiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinsoon qinsoon merged commit 33fba23 into master May 14, 2021
@qinsoon qinsoon deleted the limit-public-api branch May 14, 2021 02:25
k-sareen pushed a commit to k-sareen/mmtk-core that referenced this pull request Jun 10, 2021
* Turns public modules to private or pub crate if possible
* Removes some unused code/macros
wenyuzhao pushed a commit to wenyuzhao/mmtk-core that referenced this pull request Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-testing Run binding tests for the pull request (deprecated: use PR-extended-testing instead)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose fewer public types

3 participants