Skip to content

Fix tests from fork #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 5, 2021
Merged

Fix tests from fork #200

merged 5 commits into from
Jan 5, 2021

Conversation

qinsoon
Copy link
Member

@qinsoon qinsoon commented Jan 4, 2021

This PR allows tests running for PRs for a fork.

  • A PR from a fork cannot access secrets from the main repo. Instead use GITHUB_TOKEN which has read-only access for the fork.
  • I had to make https://github.com/mmtk/ci-perf-kit public as the perf tests need to access it.
  • As GITHUB_TOKEN does not have write permission to post comments, we cannot see perf test results as PR comments. We could still see the artifacts for the runs to check results. This could be fixed later - I will create an issue for this.

@qinsoon qinsoon added the PR-testing Run binding tests for the pull request (deprecated: use PR-extended-testing instead) label Jan 4, 2021
@qinsoon qinsoon marked this pull request as ready for review January 4, 2021 21:48
@qinsoon qinsoon requested a review from javadamiri January 4, 2021 21:49
@qinsoon qinsoon merged commit 6d210d6 into mmtk:master Jan 5, 2021
qinsoon pushed a commit to qinsoon/mmtk-core that referenced this pull request Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-testing Run binding tests for the pull request (deprecated: use PR-extended-testing instead)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants