Add alloc_with_options #1218
Merged
Add alloc_with_options #1218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wks
reviewed
Oct 30, 2024
|
I changed the documentation based on the suggestions. |
k-sareen
reviewed
Oct 30, 2024
src/memory_manager.rs
Outdated
| /// normally without panicking or throwing exceptions, this function will return zero. | ||
| /// | ||
| /// This function in most cases returns a valid memory address. | ||
| /// This function may return a zero address iif 1. MMTk attempts at least one GC, |
There was a problem hiding this comment.
Suggested change
| /// This function may return a zero address iif 1. MMTk attempts at least one GC, | |
| /// This function may return a zero address if 1. MMTk attempts at least one GC, |
There was a problem hiding this comment.
Actually this paragraph should be removed.
large object. Minor fixes for comments
wks
reviewed
Oct 31, 2024
wks
reviewed
Oct 31, 2024
Co-authored-by: Kunshan Wang <wks1986@gmail.com>
|
I’m awaiting feedback from @JunmingZhao42 and Ben before merging this PR, as they requested this feature. |
bgamari
reviewed
Nov 5, 2024
Co-authored-by: Ben Gamari <ben@smart-cactus.org>
|
I think this PR still looks good now. |
qinsoon
added a commit
to qinsoon/mmtk-core
that referenced
this pull request
Jun 3, 2025
commit 8a6cac2 Author: Yi Lin <qinsoon@gmail.com> Date: Wed May 21 05:36:29 2025 +0000 Implement SpaceInspector for all policies commit 10883f4 Author: Yi Lin <qinsoon@gmail.com> Date: Thu May 15 04:38:07 2025 +0000 Introduce SpaceInspector and RegionInspector commit c5ead72 Author: Yi Lin <qinsoon@gmail.com> Date: Mon May 12 12:42:14 2025 +1200 Choose Non-moving Policy based on features (mmtk#1308) This PR uses an Immix space as the default non moving space, and adds two features to use mark sweep or immortal as the non moving space. * `Mutator` now includes 2 Immix allocators (one for Immix as the default space, and the other for Immix as the non moving space). * Call prepare/release/end_of_gc for the non moving space. * Add `common_prepare_func` and `common_release_func` for mutators. commit 8b32d04 Author: Yi Lin <qinsoon@gmail.com> Date: Fri May 9 17:41:07 2025 +1200 Add alloc_with_options (mmtk#1218) This PR adds an alternative allocation functions `alloc_with_options`. The attached `AllocationOptions` change the allocation behavior, such as avoiding GCs and allowing overcommit. Our current `alloc` functions assume they are GC safe points and will trigger GCs internally. A runtime may have different assumptions. We see GHC has `allocateMightFail` (https://gitlab.haskell.org/ghc/ghc/-/blob/90746a591919fc51a0ec9dec58d8f1c8397040e3/rts/sm/Storage.c?page=2#L1089). Also Julia assumes perm alloc will not trigger a GC (mmtk/mmtk-julia#172). Having a variant of `alloc` that is not GC safepoints could be generally useful. --------- Co-authored-by: Kunshan Wang <wks1986@gmail.com> Co-authored-by: Ben Gamari <ben@smart-cactus.org> commit df7a1f1 Author: Yi Lin <qinsoon@gmail.com> Date: Thu May 8 15:31:41 2025 +1200 Remove V8 tests from extended tests (mmtk#1313) This PR removes V8 tests from our extended tests for mmtk-core. The V8 version we use in the binding is outdated, and the required environments are no longer supported by Github runners. See the discussion in [#ANU Research > The V8 binding is beyond repair @ 💬](https://mmtk.zulipchat.com/#narrow/channel/262677-ANU-Research/topic/The.20V8.20binding.20is.20beyond.20repair/near/509115086).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an alternative allocation functions
alloc_with_options. The attachedAllocationOptionschange the allocation behavior, such as avoiding GCs and allowing overcommit.Our current
allocfunctions assume they are GC safe points and will trigger GCs internally. A runtime may have different assumptions. We see GHC hasallocateMightFail(https://gitlab.haskell.org/ghc/ghc/-/blob/90746a591919fc51a0ec9dec58d8f1c8397040e3/rts/sm/Storage.c?page=2#L1089). Also Julia assumes perm alloc will not trigger a GC (mmtk/mmtk-julia#172).Having a variant of
allocthat is not GC safepoints could be generally useful.