Skip to content

Evaluate how much tests we do for bindings/mmtk-core with assertions turned on #979

Open
@qinsoon

Description

@qinsoon

We need to make sure we have enough tests to test MMTk with assertions. We have two levels of assertions: 1. assertions that will be enabled as debug_assertions in Rust, that is for any Rust dev/debug build, and 2. extreme assertions that are only enabled when we turn on the extreme_assertions feature in mmtk-core.

Our current tests with assertions:

  • mmtk-core
    • We run all the tests with debug_assertions.
    • We run all the tests with extreme_assertions.
  • mmtk-openjdk
    • We run the old dacapo tests with debug_assertions.
    • We run the new dacapo tests with debug_assertions.
    • We run each plan with 2 of the old dacapo benchmarks with extreme_assertions.
  • mmtk-jikesrvm
    • We run each plan with 2 benchmarks with extreme_assertions on.
    • We run fop with debug builds.
  • mmtk-v8
    • We run tests with a debug build with debug_assertions.
  • mmtk-julia
    • We use a debug build with debug_assertions to bootstrap Julia and run hello world.
  • mmtk-ruby
    • We run all the tests with debug_assertions.

In short, for mmtk-core/mmtk-openjdk/mmtk-v8/mmtk-ruby, we have no issue. We use a debug build for all the tests. For mmtk-jikesrvm and mmtk-julia, we need to improve the tests, and include more tests with a debug MMTk build.

For extreme_assertions, we only selectively run limited tests with OpenJDK and JikesRVM. We could consider running more tests with extreme_assertions for more bindings (note that not all the bindings can run with extreme_assertions).

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-opsArea: Operations (e.g. CI)C-enhancementCategory: EnhancementP-normalPriority: Normal.

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions