Description
While I was debugging heap accounting for the generational GC performance issue, I found it really hard to read and understand the PageResource
trait and its implementations: {FreeList,Monotone}PageResource
. It uses a mix of javadoc and rustdoc comment styles, and there are almost no comments explaining how or what it's doing. Since this is a core part of our virtual memory management code, I think it and its semantics should be well documented.
I note that there is a similar issue that exists (#60), but it suggests removing MonotonePageResource
for having a unified PageResource
implementation based on FreeListPageResource
. I don't know of the merits of such a refactor, since PageResource
should be thought of an interface without knowing implementation specific details, in my opinion.