Skip to content

Integrate ThirdPartyHeap into aarch64 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ArberSephirotheca
Copy link

No description provided.

@caizixian caizixian changed the title Update arraycopy_epilogue for aarch64 Update mmtk/jdk fork for aarch64 Sep 27, 2023
@caizixian caizixian self-requested a review September 27, 2023 05:54
Copy link
Member

@caizixian caizixian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please update the PR to include required changes for other files, such as assembler_aarch64.hpp, etc.?

You can use this diff and the changes under riscv as reference. openjdk/jdk@master...mmtk:jdk:jdk-21+24-mmtk

You need to include the changes to the template interpreter and the assembler to use MMTk's allocation and barriers.

Copy link
Member

@caizixian caizixian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the missing Register changes so that the object reference can be passed to MMTk barriers. However, there are a few places of arraycopy_epilogue that need to be fixed. Please see the inline comments.

Allocation related changes are currently still missing. In particular, macro assembler, C1 macro assembler, and the template interpreter need to be changed to call into MMTk for allocation.

Please refer to this diff, and pay special attention to riscv related changes, and check whether there's anything missing for aarch64. Thanks! openjdk/jdk@master...mmtk:jdk:jdk-21+24-mmtk

@caizixian caizixian changed the title Update mmtk/jdk fork for aarch64 Integrate ThirdPartyHeap into aarch64 Oct 16, 2023
@caizixian caizixian merged commit 5fc428f into mmtk:jdk-21+24-mmtk Oct 16, 2023
caizixian added a commit to mmtk/mmtk-openjdk that referenced this pull request Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants