-
Notifications
You must be signed in to change notification settings - Fork 1
Integrate ThirdPartyHeap into aarch64 #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate ThirdPartyHeap into aarch64 #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please update the PR to include required changes for other files, such as assembler_aarch64.hpp
, etc.?
You can use this diff and the changes under riscv as reference. openjdk/jdk@master...mmtk:jdk:jdk-21+24-mmtk
You need to include the changes to the template interpreter and the assembler to use MMTk's allocation and barriers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the missing Register
changes so that the object reference can be passed to MMTk barriers. However, there are a few places of arraycopy_epilogue
that need to be fixed. Please see the inline comments.
Allocation related changes are currently still missing. In particular, macro assembler, C1 macro assembler, and the template interpreter need to be changed to call into MMTk for allocation.
Please refer to this diff, and pay special attention to riscv related changes, and check whether there's anything missing for aarch64. Thanks! openjdk/jdk@master...mmtk:jdk:jdk-21+24-mmtk
No description provided.