Skip to content

Commit

Permalink
remove outdated TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
simonpcouch committed Oct 30, 2024
1 parent aa476fe commit 37e5136
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 10 deletions.
4 changes: 0 additions & 4 deletions R/directory.R
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,3 @@ filter_interfaces <- function(x) {

x[recognized]
}


# TODO: make a test directory in tests/testthat that can be relied on
# for consistent output
2 changes: 0 additions & 2 deletions R/doc-pal-cli.R
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@
#'
#' @section Cost:
#'
# TODO: make this a template that takes in the token counts and prices as input
#'
#' The system prompt from a pal includes something like 4,000 tokens.
#' Add in (a generous) 100 tokens for the code that's actually highlighted
#' and also sent off to the model and you're looking at 4,100 input tokens.
Expand Down
1 change: 0 additions & 1 deletion R/pal-add-remove.R
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
#' Cand only contain letters and numbers.
#' @param prompt A single string giving the system prompt. In most cases, this
#' is a rather long string, containing several newlines.
# TODO: only add prefix when not supplied one
#' @param interface One of `"replace"`, `"prefix"`, or `"suffix"`, describing
#' how the pal will interact with the selection. For example, the
#' [cli pal][pal_cli] `"replace"`s the selection, while the
Expand Down
3 changes: 0 additions & 3 deletions tests/testthat/test-pal-add-remove.R
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,6 @@ test_that("pal addition with bad inputs", {
.pal_add(role = identity, prompt = "hey")
)

# TODO: decide on `prompt` interface and test


expect_snapshot(
error = TRUE,
.pal_add(role = "sillyhead", prompt = "hey", interface = "no")
Expand Down

0 comments on commit 37e5136

Please sign in to comment.