Skip to content

Suppress a deprecation warning. #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Suppress a deprecation warning. #518

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f21786
Suppress a deprecation warning.
gonsolo Oct 23, 2025
da60a89
Restrict to GCC and Clang.
gonsolo Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -660,6 +660,16 @@ SET (PBRT_UTIL_SOURCE
src/pbrt/util/vecmath.cpp
)

# A warning about a deprecated function in C++17 but the solution will only be
# in C++26.
if (CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang")
set_source_files_properties(
src/pbrt/util/string.cpp
PROPERTIES
COMPILE_FLAGS "-Wno-deprecated-declarations"
)
endif()

SET (PBRT_UTIL_SOURCE_HEADERS
src/pbrt/util/args.h
src/pbrt/util/bluenoise.h
Expand Down
Loading