use Unix.file_descr for sockect #50
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, this PR is obsolete due to OCaml runtime changes. In case you want to resubmit a PR, please make sure the changes would work on both Unix and Windows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The socket method is unusable with type int, for instance with select in async mode.
This solves the problem. I think there is no way in Stdlib to convert int to Unix.file_descr so I used
the same code as OCaml uses for stdin and alike.
I did not do it in the C.stub because of the comparison with -1 and to keep the [@Untagged] flag.
Should be tested on windows because there file_descr are not int. But if there is a problem, it should
be there with or without this patch, PQsocket does return int on both platforms. So the conversion should actually
make it better on windows.