Skip to content

Port the config discovery script to pkg-config #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

anmonteiro
Copy link
Contributor

  • PostgreSQL installations also add pkg-config configuration files.
  • In cross-compilation scenarios, calling out to pg_config will list the wrong --libdir
  • This change uses pkg-config to find the C include & library flags for libpq
    • I've kept a fallback to the current pg_config-based implementation to avoid errors in cases that users don't have pkg-config in their $PATH.

also slightly related to ocaml/dune#1492 (comment)

@mmottl mmottl merged commit e690b07 into mmottl:master Nov 4, 2024
@mmottl
Copy link
Owner

mmottl commented Nov 4, 2024

Thanks for the contribution and sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants