Skip to content

jekyll-data missing since 4.16.6? #2621

Closed
@iBug

Description

@iBug

I was trying to create a localized website with this theme when I suddenly discovered that l10n was not working at all unless I include ui-text.yml in my repository. This was not what I expected as I've always had the impression that data files bundled in this theme are automatically loaded unless overridden.

It's also what the current documentation says:

Quick-Start Guide > Migrating to Gem Version

From v4.5.0 onwards, you don't have to maintain a copy of the default data files viz. _data/ui-text.yml and _data/navigation.yml either.

Tracing through Git history shows removal of jekyll-data along with jemoji in 2388cbe. I can confirm that adding jekyll-data into plugins list restores the functionality.

Looking at jekyll-data itself, ashmaroli/jekyll-data#33 might be a reason for the removal as a dependency at the time. The plugin isn't included in stock GitHub Pages, either (see GitHub Pages dependency versions). Generating a Gemfile.lock with Bundler from theme version 4.19.3 plus latest github-pages (206 ATM) shows no trace of jekyll-data.

I wonder what we should do next - add it back or update the documentation to reflect recent changes? (not quite recent at all...)

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions