missing trailing slash in structured data

[chatoo2412]

Environment

• Minimal Mistakes version: 4.13.0
• Ruby gem or remote theme version: remote
• Jekyll version: 3.7.4
• Git repository URL: https://github.com/chatoo2412/chatoo2412.github.io
• GitHub Pages hosted (if yes provide URL to site): https://chatoo2412.github.io/
• Operating system: -

Expected behavior

Structured data don't contain trailing slashes, unlike canonical URL does.
Strictly speaking, paths with and without trailing slashes are different.
Please make it consistent.

Steps to reproduce the behavior

minimal-mistakes/_includes/seo.html

Lines 126 to 147 in c8f4820

	{% if site.og_image %}
	<script type="application/ld+json">
	{
	"@context": "http://schema.org",
	"@type": "Organization",
	"url": {{ seo_url | jsonify }},
	"logo": {{ site_og_image | jsonify }}
	}
	</script>
	{% endif %}
	{% if site.social %}
	<script type="application/ld+json">
	{
	"@context": "http://schema.org",
	"@type": "{% if site.social.type %}{{ site.social.type }}{% else %}Person{% endif %}",
	"name": {{ site.social.name | default: site.name | jsonify }},
	"url": {{ seo_url | jsonify }},
	"sameAs": {{ site.social.links | jsonify }}
	}
	</script>
	{% endif %}

minimal-mistakes/_includes/seo.html

Line 3 in c8f4820

{%- assign seo_url = site.url | append: site.baseurl -%}

minimal-mistakes/_includes/seo.html

Line 17 in c8f4820

{%- assign canonical_url = page.url | replace: "index.html", "" | absolute_url %}

seo_url doesn't contain trailing slash but canonical_url does contain.

Other

[mmistakes]

Not sure I follow where the issue is. Looking at the output of the demo site a trailing slash is on both the canonical URL and social sharing.

<meta property="og:url" content="https://mmistakes.github.io/minimal-mistakes/">
<meta name="twitter:url" content="https://mmistakes.github.io/minimal-mistakes/">
<link rel="canonical" href="https://mmistakes.github.io/minimal-mistakes/">

[chatoo2412]

Thanks for your reply.
What I'm talking about is this part:

<script type="application/ld+json">
{
  "@context": "http://schema.org",
  "@type": "Organization",
  "url": "https://mmistakes.github.io/minimal-mistakes",
  "logo": "https://mmistakes.github.io/minimal-mistakes/assets/images/site-logo.png"
}
</script>

<script type="application/ld+json">
{
  "@context": "http://schema.org",
  "@type": "Person",
  "name": "Michael Rose",
  "url": "https://mmistakes.github.io/minimal-mistakes",
  "sameAs": ["https://twitter.com/mmistakes","https://facebook.com/michaelrose"]
}
</script>

As you can see, urls have no trailing slashes.

[mmistakes]

Gotcha.
I've reopened an old issue to replace my hand-rolled SEO include with jekyll-seo-tag if you want to track it.

I'm going to take another look at that as that plugin does more and has better support for for JSON+LD meta output. It's also better maintained than what I include in the theme.

cc/ #324