Disable copy button for bad pre blocks

mmistakes · May 6, 2024 · 438710d · 438710d
1 parent 4f76c25
commit 438710d
Show file tree

Hide file tree

Showing 7 changed files with 26 additions and 15 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,7 +4,7 @@
 
 ### Bug Fixes
 
-- Fix copy button going out of range for invalid syntax highlighting blocks.
+- Disable copy button on invalid syntax highlighting blocks to avoid positioning issues.
 
 ### Enhancements
 

diff --git a/_sass/minimal-mistakes/_page.scss b/_sass/minimal-mistakes/_page.scss
@@ -139,10 +139,6 @@ body {
     }
   }
 
-  pre {
-    position: relative;
-  }
-
   :not(pre) > code {
     padding-top: 0.1rem;
     padding-bottom: 0.1rem;

diff --git a/assets/js/_main.js b/assets/js/_main.js
@@ -206,7 +206,7 @@ $(document).ready(function () {
 
   if (window.enable_copy_code_button) {
     document
-      .querySelectorAll(".page__content pre > code")
+      .querySelectorAll(".page__content pre.highlight > code")
       .forEach(function (element, index, parentList) {
         // Locate the <pre> element
         var container = element.parentElement;

diff --git a/assets/js/main.min.js b/assets/js/main.min.js
diff --git a/assets/js/main.min.js.map b/assets/js/main.min.js.map
diff --git a/docs/_docs/18-history.md b/docs/_docs/18-history.md
@@ -5,7 +5,7 @@ permalink: "/docs/history/"
 excerpt: Change log of enhancements and bug fixes made to the theme.
 sidebar:
   nav: docs
-last_modified_at: '2024-05-06T21:06:31+08:00'
+last_modified_at: '2024-05-06T21:15:29+08:00'
 toc: false
 ---
 
@@ -19,7 +19,7 @@ toc: false
 
 ### Bug Fixes
 
-- Fix copy button going out of range for invalid syntax highlighting blocks.
+- Disable copy button on invalid syntax highlighting blocks to avoid positioning issues.
 
 ### Enhancements
 

diff --git a/docs/_posts/2009-10-06-edge-case-broken-highlighting.md b/docs/_posts/2009-10-06-edge-case-broken-highlighting.md
@@ -21,13 +21,28 @@ if str
 end
 ```
 
+Good (but dumb) highlighting:
+
+```
+str = ARGV.first
+if str
+  str = str.b[/\A_(.*)_\z/, 1]
+  if str and Gem::Version.correct?(str)
+    version = str
+    ARGV.shift
+  end
+end
+```
+
 Bad highlighting:
 
 ```invalid
-if Gem.respond_to?(:activate_bin_path)
-  load Gem.activate_bin_path('jekyll', 'jekyll', version)
-else
-  gem "jekyll", version
-  load Gem.bin_path("jekyll", "jekyll", version)
+str = ARGV.first
+if str
+  str = str.b[/\A_(.*)_\z/, 1]
+  if str and Gem::Version.correct?(str)
+    version = str
+    ARGV.shift
+  end
 end
 ```