Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setWorkingDirectory #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update setWorkingDirectory #2

wants to merge 1 commit into from

Conversation

ritey
Copy link

@ritey ritey commented Oct 5, 2015

Check the override is writeable not the default and call internally the
new function not the old

Check the override is writeable not the default and call internally the
new function not the old
@mmerian
Copy link
Owner

mmerian commented Oct 5, 2015

Hi david,

Thanks for contributing.
My goal with this repo is to have a composer-installable version of phpcrawl. I would no like to start modifying the core of PHPCrawl, since we sould have to backport the changes each time the phpcrawl code is updated.

Maybe extending the PHPCrawler class would be a better solution for you. You could depend on this repo in your composer.json and add a new class extending th base one that modifies the behavior so that it suits your needs.

Cheers,

Maxime

@ritey
Copy link
Author

ritey commented Oct 5, 2015

Hi Maxime,

Thanks, I agree improving the core would be ideal, if only it was moved into Git and actively developed. Seems like it's gone stale :(

Cheers

Dave

@crispy-computing-machine

As there have been no updates to the main project in 4 years I am making minor fixes/improvements on phpcrawl here: https://github.com/crispy-computing-machine/phpcrawl - Pull requests welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants