Skip to content

Handle links prefixed with spaces in atom #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oprudkyi wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Handle links prefixed with spaces in atom #238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/shared/xmlbase.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ func resolveAttrs(p *xpp.XMLPullParser) error {

// resolve u relative to b
func XmlBaseResolveUrl(b *url.URL, u string) (*url.URL, error) {
relURL, err := url.Parse(u)
relURL, err := url.Parse(strings.TrimLeft(u, " "))
if err != nil {
return nil, err
}
Expand Down
13 changes: 13 additions & 0 deletions testdata/parser/atom/atom10_feed_entry_link_href_invalid_space_prefix.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
{
"entries": [
{
"links": [
{
"rel": "alternate",
"href": "http://example.org"
}
]
}
],
"version": "1.0"
}
8 changes: 8 additions & 0 deletions testdata/parser/atom/atom10_feed_entry_link_href_invalid_space_prefix.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
<!--
Description: entry link - space prefixed href
-->
<feed xmlns="http://www.w3.org/2005/Atom">
<entry>
<link href=" http://example.org"></link>
</entry>
</feed>