Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility with Dart 2.10. #217

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Compatibility with Dart 2.10. #217

wants to merge 14 commits into from

Conversation

trygvis
Copy link

@trygvis trygvis commented Oct 15, 2020

This depends on mmcc007/tool_base#2, mmcc007/tool_mobile#1 and mmcc007/fake_process_manager#1.

These changes has been done as a part of getting screenshots to work with Dart 2.10. The new screenshots work in the same way as earlier builds for my app.

@trygvis trygvis mentioned this pull request Oct 15, 2020
Open
@trygvis
Copy link
Author

trygvis commented Oct 15, 2020

This fixes #215.

@mazzonem
Copy link

mazzonem commented Mar 4, 2021

@mmcc007 Would you be happy to merge this? #215 seems to be a fairly large issue now that Flutter 2.0 is in Stable.

Thanks in advance 🙏

@clangenb
Copy link

I would also be happy if this is merged.

I think screenshots would be a valuable tool, but the unresponsiveness worries me a bit.

@felixwortmann
Copy link

Is anyone willing to publish a working fork of screenshots if there is no activity soon?

I think this is a great project and it would help a lot of developers.

@M123-dev
Copy link

Ping @mmcc007

@teolemon
Copy link

@trygvis can you try solving the unit tests in the PR so that it's an easier "sell" to merge the PR ? I'm going to try reaching out to @mmcc007

@trygvis
Updating apps
e124be1
@trygvis
wip: Updating code.
3bc49a5
@trygvis
wip: Generating code from screens.yaml
4613016 
Necessary to replace the 'resources' package.
@trygvis
wip: nits
cdcf0e8
@trygvis
wip: Working imagemagick detection
78f3390
@trygvis
wip: small progress
e37e05e 
Fixing many small bugs, lots of null pointers and badly converted
code.
@trygvis
wip: small progress
cabee71 
Don't hang forever on devices where we're unable to change the locale.
@trygvis
Copy link
Author

trygvis commented Oct 28, 2021

@teolemon I've done some work on trying to get it up to date with the latest dart/flutter releases but it is a fair bit of work. Any help and testing would be appreciated. I've worked out a good number of bugs, but I'm sure there are more remaining.

All my work is done on my fork for now.

@trygvis
wip: flavors: nullability fixes
208580b
@trygvis
wip: Adding missing deps
e12b860
@trygvis
wip: Better type annotations
1d456b9
@trygvis
wip: modernization
afa46dd
@trygvis
wip
77cd300 
Some code is now working, but the response from the Flutter daemon in
startEmulator() doesn't include the emulatorId (emulator-5554) so we
don't know how to talk to adb.
@teolemon
Copy link

teolemon commented Jan 9, 2022

Thank you very much @trygvis 🎉
@mmcc007 does not seem to be reacting. We might opt for a new repository, and publish to pub.dev ?

@M123-dev
Copy link

M123-dev commented Jan 9, 2022

Sounds good, but this seems to be a very essential plugin, depending on how much time you @trygvis want to invest here you could also ask fluttercommunity if you could transfer your repository over there. Just as an idea

This was referenced Jan 12, 2022
Open
Open
Open
Open
Open
@DeanPack
Copy link

DeanPack commented Apr 1, 2022

Found this thread here about bringing it up to date. Can I get an update on when this could be useable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fahu fahu fahu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@trygvis @mazzonem @clangenb @felixwortmann @M123-dev @teolemon @DeanPack @fahu