Add animation type for the modal #780
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The library is reimplementing the slide animation for the modal. React native implements three types of the animation: 'slide' (current implementation), 'fade' and 'none' and the
animationType
from themodalPropsIOS
is not changing the animation type.The change is reimplementing the three animations and add a better typing for the
modalPropsIOS
.Before - Not working code
Test Plan
ScreenRecording_08-04-2025.13.MOV
ScreenRecording_08-04-2025.12.mov
ScreenRecording_08-04-2025.11-44-39_1.MOV
After - Working code