Skip to content

allow erroring in navigateresult directly #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cheesycod
Copy link

Closes #581 which I made earlier for this. Adds a new NavigateError::Error variant to allow directly erroring luau require while in resolution process itself

@cheesycod
Copy link
Author

cheesycod commented May 15, 2025

OK, I am slightly unsure about this myself as rawlua init from ptr causes memory leaks on my mac requiring aggressive gc to clean up the mess rawlua leaves behind

@khvzak do you know any better api than rawlua::init_from_ptr since init from ptr causes hard to debug memory leaks right now that sometimes don’t even get resolved with gc when using it (this was actually the issue I had with mluas first require implementation before it switched to a luau function, init from ptr memory leaks like crazy)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow erroring in LuaRequire returns
1 participant