Skip to content

Commit

Permalink
lib: name anonymous callbacks
Browse files Browse the repository at this point in the history
This commit is to help in the effort to name all anonymous
functions to help when heap debugging. Specifically, this commit
fixes some anonymous functions used as listeners in the lib/ folder.

Refs: nodejs#8913
  • Loading branch information
mlrv authored and Trott committed Aug 1, 2018
1 parent 2bdcdfc commit 607ee37
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions lib/_http_outgoing.js
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ OutgoingMessage.prototype.setTimeout = function setTimeout(msecs, callback) {
}

if (!this.socket) {
this.once('socket', function(socket) {
this.once('socket', function socketOnceCallback(socket) {
socket.setTimeout(msecs);
});
} else {
Expand All @@ -200,7 +200,7 @@ OutgoingMessage.prototype.destroy = function destroy(error) {
if (this.socket) {
this.socket.destroy(error);
} else {
this.once('socket', function(socket) {
this.once('socket', function socketOnceCallback(socket) {
socket.destroy(error);
});
}
Expand Down
2 changes: 1 addition & 1 deletion lib/_tls_common.js
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ exports.translatePeerCertificate = function translatePeerCertificate(c) {
c.infoAccess = Object.create(null);

// XXX: More key validation?
info.replace(/([^\n:]*):([^\n]*)(?:\n|$)/g, function(all, key, val) {
info.replace(/([^\n:]*):([^\n]*)(?:\n|$)/g, function replacerCallback(all, key, val) {
if (key in c.infoAccess)
c.infoAccess[key].push(val);
else
Expand Down

0 comments on commit 607ee37

Please sign in to comment.