-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Jupyter] Add RBAC #85
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
e7d514f
Create role.yaml
eliyahu77 86ec738
Update role.yaml
eliyahu77 28fa4a6
Create role-binding.yaml
eliyahu77 f8679cf
Update values.yaml
eliyahu77 ea0a95e
Create serviceaccount.yaml
eliyahu77 5bb7999
Update Chart.yaml
eliyahu77 4052bf1
Update deployment.yaml
eliyahu77 b6f078d
Update charts/mlrun-ce/templates/jupyter-notebook/role-binding.yaml
eliyahu77 be8c1d9
Update charts/mlrun-ce/templates/jupyter-notebook/role-binding.yaml
eliyahu77 11357dc
Update charts/mlrun-ce/templates/jupyter-notebook/role-binding.yaml
eliyahu77 d65f187
Update charts/mlrun-ce/templates/jupyter-notebook/serviceaccount.yaml
eliyahu77 609baf1
Update charts/mlrun-ce/templates/jupyter-notebook/serviceaccount.yaml
eliyahu77 a69858d
Update deployment.yaml
eliyahu77 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
charts/mlrun-ce/templates/jupyter-notebook/role-binding.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| {{- if .Values.jupyterNotebook.enabled -} | ||
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| kind: RoleBinding | ||
| metadata: | ||
| name: jupyter-role-binding | ||
| subjects: | ||
| - kind: ServiceAccount | ||
| name: {{ .Values.jupyterNotebook.serviceAccount.name }} | ||
| roleRef: | ||
| kind: Role | ||
| name: jupyter-role | ||
| apiGroup: rbac.authorization.k8s.io | ||
| {{- end -}} | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| {{- if .Values.jupyterNotebook.enabled -} | ||
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| kind: Role | ||
| metadata: | ||
| name: jupyter-role | ||
| rules: | ||
| - apiGroups: | ||
| - "" | ||
| resources: | ||
| - pods | ||
| verbs: | ||
| - get | ||
| - list | ||
| - watch | ||
| - create | ||
| - delete | ||
| - apiGroups: | ||
| - "" | ||
| resources: | ||
| - pods/log | ||
| verbs: | ||
| - get | ||
| - list | ||
| - apiGroups: | ||
| - metrics.k8s.io | ||
| resources: | ||
| - pods | ||
| verbs: | ||
| - list | ||
| - get | ||
| - apiGroups: | ||
| - "" | ||
| resources: | ||
| - services | ||
| verbs: | ||
| - list | ||
| - get | ||
| - apiGroups: | ||
| - extensions | ||
| resources: | ||
| - ingresses | ||
| verbs: | ||
| - list | ||
| - get | ||
| - apiGroups: | ||
| - "" | ||
| resources: | ||
| - secrets | ||
| verbs: | ||
| - create | ||
| {{- end -}} |
6 changes: 6 additions & 0 deletions
6
charts/mlrun-ce/templates/jupyter-notebook/serviceaccount.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| {{- if .Values.jupyterNotebook.serviceAccount.create -} | ||
| apiVersion: v1 | ||
| kind: ServiceAccount | ||
| metadata: | ||
| name: {{ .Values.jupyterNotebook.serviceAccount.name }} | ||
| {{- end -}} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if
.Values.jupyterNotebook.serviceAccount.nameis empty? The user may ask tocreatebut not provide a name (by mistake or not). Should we use a default name here in that case?