vignette progress

mlr-org · Aug 26, 2023 · 26fb1f3 · 26fb1f3
1 parent 4430ea8
commit 26fb1f3
Show file tree

Hide file tree

Showing 3 changed files with 194 additions and 180 deletions.
diff --git a/R/ParamSet.R b/R/ParamSet.R
@@ -219,10 +219,13 @@ ParamSet = R6Class("ParamSet",
       }
       extra_trafo = self$extra_trafo
       if (!is.null(extra_trafo)) {
+        # need to give the input of extra_trafo a different name than the output; otherwise the user would have to
+        # "force()" the x-argument of extra_trafo.
+        xin = x
         if (test_function(extra_trafo, args = c("x", "param_set"))) {
-          x = extra_trafo(x = x, param_set = param_set)
+          x = extra_trafo(x = xin, param_set = param_set)
         } else {
-          x = extra_trafo(x)
+          x = extra_trafo(xin)
         }
       }
       x

diff --git a/R/ParamSetCollection.R b/R/ParamSetCollection.R
@@ -161,9 +161,11 @@ ParamSetCollection = R6Class("ParamSetCollection", inherit = ParamSet,
       changed = unlist(lapply(private$.children_with_trafos, function(set_index) {
         changing_ids = private$.translation[J(set_index), id, on = "owner_ps_index"]
         trafo = private$.sets[[set_index]]$extra_trafo
-        changing_values = x[names(x) %in% changing_ids]
-        names(changing_values) = private$.translation[names(changing_values), original_id]
-        changing_values = trafo(changing_values)
+        changing_values_in = x[names(x) %in% changing_ids]
+        names(changing_values_in) = private$.translation[names(changing_values_in), original_id]
+        # input of trafo() must not be changed after the call; otherwise the trafo would have to `force()` it in
+        # some circumstances.
+        changing_values = trafo(changing_values_in)
         prefix = names(private$.sets)[[set_index]]
         if (prefix != "") {
           names(changing_values) = sprintf("%s.%s", prefix, names(changing_values))