-
-
Notifications
You must be signed in to change notification settings - Fork 20
Update parameters and dependencies of all learners #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for cleaning up! |
Codecov Report
@@ Coverage Diff @@
## master #46 +/- ##
==========================================
- Coverage 97.61% 97.53% -0.08%
==========================================
Files 18 18
Lines 630 691 +61
==========================================
+ Hits 615 674 +59
- Misses 15 17 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could add parameters like offset, contrast and singular.ok to LogReg and LM? But they were not included in mlr. Do we want this?
If there is no reason mentioned why they were omitted: Then yes, add them. Most likely they were added recently and just not updated yet in mlr2.
Could you please add the changes to NEWS.md
? Not every single param ofc, just mentioning all updated learners and maybe version info for bigger changes like glmnet and xgboost.
Co-Authored-By: Patrick Schratz <patrick.schratz@gmail.com>
Co-Authored-By: Patrick Schratz <patrick.schratz@gmail.com>
Co-Authored-By: Patrick Schratz <patrick.schratz@gmail.com>
Closes #9
Closes #27
Glmnet
Updated to glmnet 3.0
KKNN
Not sure if
y-kernel
should be implementedLDA
LogReg
NaiveBayes
QDA
Ranger
SVM
Xgboost
Parameters updated in Update xgboost learner to latest CRAN version #31
KM
LM
CV
parameter for internal cross-validation are not includedShould we include
na.action
if the options are fail or omit records with missing values? This would add themissing
property to the learner but only ifna.action
is set toomit
. Some of the learners in the list support this.We could add parameters like
offset
,contrast
andsingular.ok
toLogReg
andLM
? But they were not included inmlr
. Do we want this?