Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support selected features in glmnet #200

Merged
merged 2 commits into from
Aug 12, 2021
Merged

Support selected features in glmnet #200

merged 2 commits into from
Aug 12, 2021

Conversation

mllg
Copy link
Member

@mllg mllg commented Aug 4, 2021 •
edited
Loading

also many cleanups

@mllg
Copy link
Member Author

mllg commented Aug 4, 2021

First step towards #28 ?

@mllg
Copy link
Member Author

mllg commented Aug 9, 2021

Summary of my changes:

  • Implemented helper functions to avoid lot of copy-paste code (see helper_glmnet.R)
  • Cleaned up paramset, I believe there were some copy-paste errors
  • Added selected_features() method.

@mllg mllg merged commit 2a49272 into main Aug 12, 2021
@mllg mllg deleted the glmnet_selected_features branch August 12, 2021 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaphaelS1 RaphaelS1 RaphaelS1 approved these changes

@adibender adibender Awaiting requested review from adibender

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mllg @RaphaelS1