Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update glmnet #197

Merged
merged 1 commit into from
Jul 27, 2021
Merged

Update glmnet #197

merged 1 commit into from
Jul 27, 2021

Conversation

adibender
Copy link
Collaborator

No description provided.

@adibender
Copy link
Collaborator Author

Besides the fix we discussed, I also changed the docu and added a warning when s is reset to the default. But we might upgrade to an error. I can't see a scenario where fitting multiple lamdas and setting s = 0.01 is actually wanted.

@mllg mllg merged commit bc7bb96 into main Jul 27, 2021
@mllg mllg deleted the update-glmnet branch July 27, 2021 09:45
@mllg
Copy link
Member

mllg commented Jul 27, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berndbischl berndbischl Awaiting requested review from berndbischl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adibender @mllg