Skip to content

Add help method for filters #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 14, 2020
Merged

Add help method for filters #68

merged 4 commits into from
Mar 14, 2020

Conversation

mllg
Copy link
Member

@mllg mllg commented Mar 12, 2020

fixes #59

@@ -47,7 +47,8 @@ FilterVariance = R6Class("FilterVariance", inherit = Filter,
task_type = task_type,
param_set = param_set,
feature_types = feature_types,
packages = packages
packages = packages,
man = "mlr3filters::mlr_filters_performance"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is a typo.

R/FilterAUC.R Outdated
@@ -52,7 +52,8 @@ FilterAUC = R6Class("FilterAUC", inherit = Filter,
task_type = task_type,
task_properties = task_properties,
feature_types = feature_types,
packages = packages
packages = packages,
man = "mlr3filters::mlr_filters_anova"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this should be mlr_filters_auc.

@codecov-io
Copy link

codecov-io commented Mar 14, 2020

Codecov Report

Merging #68 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #68   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines          245       265   +20     
=========================================
+ Hits           245       265   +20     
Impacted Files Coverage Δ
R/Filter.R 100.00% <100.00%> (ø)
R/FilterAUC.R 100.00% <100.00%> (ø)
R/FilterAnova.R 100.00% <100.00%> (ø)
R/FilterCMIM.R 100.00% <100.00%> (ø)
R/FilterCarScore.R 100.00% <100.00%> (ø)
R/FilterCorrelation.R 100.00% <100.00%> (ø)
R/FilterDISR.R 100.00% <100.00%> (ø)
R/FilterFindCorrelation.R 100.00% <100.00%> (ø)
R/FilterImportance.R 100.00% <100.00%> (ø)
R/FilterInformationGain.R 100.00% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64e9a51...37827f0. Read the comment docs.

@pat-s pat-s merged commit 12af76f into master Mar 14, 2020
@pat-s pat-s deleted the help_method branch March 14, 2020 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement $help() method
3 participants