Skip to content

Simplify installing packages #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 8, 2021
Merged

Simplify installing packages #728

merged 7 commits into from
Nov 8, 2021

Conversation

mllg
Copy link
Member

@mllg mllg commented Nov 5, 2021

Fixes #617.

Supported:

install_pkgs(<any R6 with field "packages">)
install_pkgs(ResampleResult)
install_pkgs(BenchmarkResult)

Field packages is still a simple character vector with CRAN package names and github repos ("[user]/[repo]").
In the future we can allow additional soures via prefixing, e.g. "gitlab://".

@mllg mllg requested a review from RaphaelS1 November 8, 2021 09:27
@mllg
Copy link
Member Author

mllg commented Nov 8, 2021

@RaphaelS1 Would this rather minimal approach suffice for you?

@RaphaelS1
Copy link
Contributor

It looks good to me! Will need to delete similar functions in extralearners. It might be helpful to add ..., especially as adding upgrade=FALSE might be common for installing from GitHub

@mllg
Copy link
Member Author

mllg commented Nov 8, 2021

Added ... and removed superfluous arguments.

@mllg mllg merged commit f453613 into main Nov 8, 2021
@mllg mllg deleted the install_pkgs branch November 8, 2021 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance learner package handling
2 participants