Skip to content

Add timeout field to learners #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 18, 2020
Merged

Add timeout field to learners #556

merged 4 commits into from
Nov 18, 2020

Conversation

mllg
Copy link
Member

@mllg mllg commented Sep 29, 2020

Requires mlr3misc-0.6.0.

@mllg
Copy link
Member Author

mllg commented Sep 29, 2020

Fixes #556.

@jakob-r
Copy link
Member

jakob-r commented Sep 29, 2020

This only has effect if $encapsulate = c(train = "callr", predict = "callr") is set (or similar). right? Or does it always work? It somehow feels like it should be an encapsulation parameter and not a Parameter of the Learner-Object. Then we could also have memory limits etc following a similar API?

@mllg
Copy link
Member Author

mllg commented Sep 29, 2020

This only has effect if $encapsulate = c(train = "callr", predict = "callr") is set (or similar). right?

Also works with "none" and "encapsulate", but only during user interrupts.

It somehow feels like it should be an encapsulation parameter and not a Parameter of the Learner-Object. Then we could also have memory limits etc following a similar API?

Agreed, but I couldn't come up with more options. Limiting memory is not really possible with R.

@mllg mllg merged commit 3999ab0 into master Nov 18, 2020
@mllg mllg deleted the timeout branch November 18, 2020 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants