Skip to content

Update tree_method values for XGBoost learners #2701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 7, 2019
Merged

Update tree_method values for XGBoost learners #2701

merged 7 commits into from
Dec 7, 2019

Conversation

albersonmiranda
Copy link
Contributor

@albersonmiranda albersonmiranda commented Dec 6, 2019

Added 'auto', 'approx' and 'gpu_hist' to tree_method param for XGBoost learners.

According to https://xgboost.readthedocs.io/en/latest/parameter.html

Is that ok, @pat-s ?

@larskotthoff
Copy link
Member

Does this require a specific version of xgboost? Would be great if you could update that in DESCRIPTION.

`tree_method = c("hist", "gpu_hist")` added in XGBoost v0.7 back in december/2017.
@albersonmiranda
Copy link
Contributor Author

albersonmiranda commented Dec 7, 2019

@larskotthoff sorry about that. It was indeed added in XGBoost v0.7 back in december/2017. Updated.

@pat-s
Copy link
Member

pat-s commented Dec 7, 2019

Thanks!

@larskotthoff larskotthoff merged commit e1fbe9f into mlr-org:master Dec 7, 2019
@albersonmiranda albersonmiranda deleted the patch-1 branch December 8, 2019 08:25
vrodriguezf pushed a commit to vrodriguezf/mlr that referenced this pull request Jan 16, 2021
* Update classif.Xgboost learner

added tree_method values and chaged default

* Update RLearner_regr_xgboost.R

* Update DESCRIPTION

`tree_method = c("hist", "gpu_hist")` added in XGBoost v0.7 back in december/2017.

* add NEWS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants