Enable multiclass classification with plsdaCaret #2621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pat-s
reviewed
Jul 16, 2019
| @@ -36,3 +36,41 @@ test_that("classif_plsdaCaret", { | |||
| testProbParsets("classif.plsdaCaret", binaryclass.df, binaryclass.target, binaryclass.train.inds, | |||
| old.probs.list, parset.list) | |||
| }) | |||
|
|
|||
There was a problem hiding this comment.
Please remove the unnecessary empty lines below.
pat-s
reviewed
Jul 16, 2019
| old.predicts.list, parset.list) | ||
| testProbParsets("classif.plsdaCaret", multiclass.df, multiclass.target, multiclass.train.inds, | ||
| old.probs.list, parset.list) | ||
|
|
There was a problem hiding this comment.
This line is also not not needed.
pat-s
requested changes
Jul 16, 2019
There was a problem hiding this comment.
Thanks! I haven't used plsda myself yet so I am not aware if there are theoretical issues fir multiclass tasks.
If tests are working, I see no point why we should not add the multiclass property.
Providing a screenshot of your local tests is nice but not really needed since Travis will do the work :)
Could you add an entry to NEWS.md?
|
I removed 3 lines and applied |
pat-s
approved these changes
Jul 18, 2019
|
Thanks for contributing! |
vrodriguezf
pushed a commit
to vrodriguezf/mlr
that referenced
this pull request
Jan 16, 2021
* Property "multiclass" added to learner plsdaCaret * Test for multiclass classif_plsdaCaret * Empty lines removed * Update NEWS.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #2620.
Locally the new tests pass:
