A simple fix for occasional errors when using sffs #2486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bmihaljevic Thanks for contributing.
|
bmihaljevic
changed the title
|
More importantly : doesn't this need a test? |
|
I have just added a simple test that ensures that the minimal example from #2485 no longer raises an error. |
larskotthoff
requested changes
Nov 16, 2018
|
Hi, |
|
@larskotthoff Should we merge this? We now have a test. I don't know if the proposed change could break anything else but as long as the build is passing... We should also add a NEWS entry. |
larskotthoff
approved these changes
Mar 17, 2019
|
Did the travis build for this pass? It seemed to not want to start earlier. |
|
Yours passed and I just added an NEWS entry, therefore I did not wait. Master is green. |
|
Ok, thanks! |
vrodriguezf
pushed a commit
to vrodriguezf/mlr
that referenced
this pull request
Jan 16, 2021
* This fixes mlr-org#2485 * add a test for the mlr-org#2485 fix * conform coding style and reduce test time * Update test_featsel_selectFeaturesSequential.R * NEWS for mlr-org#2486
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one-line fix for #2485. The issue is related to occasional crashing when using
sffsfeature selection.