getResamplingIndices(): Translate inner resampling indices to outer indices #2413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As a side not: I moved The type safetyness of |
Merge branch 'master' into getresampinds # Conflicts: # DESCRIPTION
|
There seem to be a lot of spurious/outdated changes in this branch. Could you please check that? |
larskotthoff
approved these changes
Oct 4, 2018
|
have to check what's wrong in the example. |
larskotthoff
reviewed
Oct 4, 2018
| p = resample(tune_wrapper, ct, outer, show.info = FALSE, | ||
| extract = getTuneResult) | ||
|
|
||
| inner_inds = getResamplingIndicesNew(p, inner = TRUE) |
|
Thanks, merging. |
vrodriguezf
pushed a commit
to vrodriguezf/mlr
that referenced
this pull request
Jan 16, 2021
…ndices (mlr-org#2413) * update getResamplingIndices() * add explicit return statement * add test checking translation of inner indices * move purrr from suggests to imports and remove explicit importing notation * no pipes * remove duplicate fields * fix description * fix typo in tests * set_names() needs to be one level higher * update NEWS.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2409
So they match the task indices.
The test I added uses a basic "CV" with predefined indices (
fixed = TRUE) since this resamp method groups the indices (1:30, 31:60, 61:90, etc) and the translation checking is more easy to understand.The implementation is ofc hard to review since it uses three nested
map()calls. But I think there is no other way to implement this.The test essentially checks that in the inner inds have values that go up to the max index value of the task (in this case 150). Before, the max of inner inds was "obs - (obs/nfolds)", which evaluates to 120 in this test with 150 obs.
Can only be merged after #2412 since it uses code from this PR.