Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bool form signature of several callback methods #382

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

DiscreteLogarithm
Copy link
Contributor

No description provided.

Copy link

mlpack-bot bot commented Nov 6, 2023

Thanks for opening your first pull request in this repository! Someone will review it when they have a chance. In the mean time, please be sure that you've handled the following things, to make the review process quicker and easier:

  • All code should follow the style guide
  • Documentation added for any new functionality
  • Tests added for any new functionality
  • Tests that are added follow the testing guide
  • Headers and license information added to the top of any new code files
  • HISTORY.md updated if the changes are big or user-facing
  • All CI checks should be passing

Thank you again for your contributions! 👍

@zoq
Copy link
Member

zoq commented Nov 8, 2023

@mlpack-jenkins test this please

Copy link
Member

@zoq zoq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch.

@DiscreteLogarithm
Copy link
Contributor Author

Thank you for your great software :)

Copy link

@mlpack-bot mlpack-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second approval provided automatically after 24 hours. 👍

@rcurtin
Copy link
Member

rcurtin commented Nov 9, 2023

Thanks! I pushed a changelog entry to HISTORY.md. If you want to add your name to COPYRIGHT.txt please do feel free 😄 I want to make a follow-up PR to update documentation in a couple places, I'll do that shortly.

@DiscreteLogarithm
Copy link
Contributor Author

Thank you as well.

If you want to add your name to COPYRIGHT.txt please do feel free 😄

No it's fine.

@zoq zoq merged commit 2263263 into mlpack:master Nov 10, 2023
0 of 2 checks passed
@zoq
Copy link
Member

zoq commented Nov 10, 2023

Thanks again for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants